Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(terraform): support variable rendering for default objects in vars #4650

Merged
merged 3 commits into from
Mar 13, 2023
Merged

feat(terraform): support variable rendering for default objects in vars #4650

merged 3 commits into from
Mar 13, 2023

Conversation

gruebel
Copy link
Contributor

@gruebel gruebel commented Mar 12, 2023

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

  • adds support for default object values in variables
  • fixes an issue with base64 encode default values bing treated as an equal condition

Fixes #4395

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gruebel gruebel marked this pull request as ready for review March 12, 2023 16:16
@gruebel gruebel merged commit 0fbd406 into bridgecrewio:main Mar 13, 2023
@gruebel gruebel deleted the support-default-objects branch March 13, 2023 20:44
praveen-panw pushed a commit to praveen-panw/bc_checkov that referenced this pull request Mar 14, 2023
@gruebel @actions-user
feat(terraform): support variable rendering for default objects in va…
8715232 
…rs (bridgecrewio#4650)

* support variable rendering for default objects in vars

* fix PR comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tronxd tronxd tronxd approved these changes

@bo156 bo156 bo156 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CKV_AZURE_109 fails with nested variables
3 participants
@gruebel @tronxd @bo156