fix(secrets): Don't show stack trace in failures when uploading secrets to verify #4734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gruebel
reviewed
Mar 23, 2023
checkov/common/bridgecrew/wrapper.py
Outdated
| @@ -42,6 +42,17 @@ def _put_json_object(s3_client: BaseClient, json_obj: Any, bucket: str, object_p | |||
| raise | |||
|
|
|||
|
|
|||
| def _put_json_object_quiet(s3_client: BaseClient, json_obj: Any, bucket: str, object_path: str) -> None: | |||
There was a problem hiding this comment.
how about using the original function and add default parameter add_stack_trace: bool = True and pass it to exc_info= 🙂
There was a problem hiding this comment.
That was my first try, but something didn't work, now it seems fine the second time 😄
lirshindalman
approved these changes
Mar 26, 2023
arielkru
approved these changes
Mar 26, 2023
Teko012
pushed a commit
to Teko012/checkov_fork_bridgecrewio
that referenced
this pull request
Mar 26, 2023
…ts to verify (bridgecrewio#4734) * don't show stack trace on errors to upload secrets * client error * lint * review --------- Co-authored-by: Eliran Turgeman <elturgeman@paloaltonetworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
When failing to upload due to access denied, we printed the entire stack trace.
This PR suppresses that behavior, and prints only the log messages.
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
New/Edited policies (Delete if not relevant)
Description
Include a description of what makes it a violation and any relevant external links.
Fix
How does someone fix the issue in code and/or in runtime?
Checklist: