Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gitlab): fixing include scope that predominant all others #4735

Merged
merged 3 commits into from Mar 23, 2023
Merged

fix(gitlab): fixing include scope that predominant all others #4735

merged 3 commits into from Mar 23, 2023

Conversation

marynaKK
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@marynaKK marynaKK changed the title fix(gitlab) - fixing include scope that predominant all others fix(gitlab): fixing include scope that predominant all others Mar 23, 2023
@maxamel
Copy link
Contributor

maxamel commented Mar 23, 2023

Nice! 🚀
Can you add also variables and cache to the list of skips?

gruebel
gruebel approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍪

@marynaKK marynaKK merged commit 83c00f7 into main Mar 23, 2023
@marynaKK marynaKK deleted the fix-gitlab-ci branch March 23, 2023 14:14
JamesWoolfenden pushed a commit that referenced this pull request Mar 23, 2023
@marynaKK @actions-user
fix(gitlab): fixing include scope that predominant all others (#4735)
2f79e00 
* fixing include scope that predominant all others

* add depth fix

* add more to skips
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxamel maxamel maxamel approved these changes

@gruebel gruebel gruebel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marynaKK @maxamel @gruebel