fix(secrets): Compare abs paths in SecretsOmitter #4756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gruebel
approved these changes
Mar 26, 2023
| check_line_range = check.file_line_range | ||
|
|
||
| if check_file_path not in files_with_secrets or not check_line_range or None in check_line_range: | ||
| if (check_file_path not in files_with_secrets and check_abs_file_path not in files_with_secrets)\ |
There was a problem hiding this comment.
feels weird to need to do both file path checks, but we probably can't know, which one is stored in files_with_secrets 😢
There was a problem hiding this comment.
Yeah since it's up to each Runner to decide how the record is stored I guess that in this case, we are better off checking both fields instead of trying to align everything :/
omryMen
approved these changes
Mar 26, 2023
Teko012
pushed a commit
to Teko012/checkov_fork_bridgecrewio
that referenced
this pull request
Mar 26, 2023
compare to abs path in secrets omitter Co-authored-by: Eliran Turgeman <elturgeman@paloaltonetworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Before, we only compared by relative path, which might be easily affected by how each framework saves the record.
Now we also compare the absolute path of the record, which solves a bug where secrets were not omitted from a terraform record.
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
New/Edited policies (Delete if not relevant)
Description
Include a description of what makes it a violation and any relevant external links.
Fix
How does someone fix the issue in code and/or in runtime?
Checklist: