Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(terraform): Length resolvers evaluate length of dict as 1. #4808

Merged
merged 1 commit into from
Apr 2, 2023

Conversation

bschwab003
Copy link
Contributor

@bschwab003 bschwab003 commented Mar 30, 2023

See #4751

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #4751

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:

  • [ X ] My code follows the style guidelines of this project
  • [ X ] I have performed a self-review of my own code
  • [ X ] I have commented my code, particularly in hard-to-understand areas
  • [ X ] I have made corresponding changes to the documentation
  • [ X ] I have added tests that prove my feature, policy, or fix is effective and works
  • [ X ] New and existing tests pass locally with my changes
  • [ X ] Any dependent changes have been merged and published in downstream modules

@gruebel gruebel changed the title feat(terraform): Length resolvers evaluate length of dict as 1. fix(terraform): Length resolvers evaluate length of dict as 1. Mar 31, 2023
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks great work 🥇

@nimrodkor nimrodkor merged commit c0e249c into bridgecrewio:main Apr 2, 2023
36 checks passed
gruebel pushed a commit that referenced this pull request Apr 2, 2023
Update the existing "length" operators to evaluate dict objects as a length of 1.  See #4751

Co-authored-by: Brian Schwab <brian.m.schwab@pwc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

length_* YAML Operators
3 participants