Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(openapi): Fix CKV_OpenAPI_20 #5302

Merged
merged 2 commits into from
Jul 9, 2023
Merged

fix(openapi): Fix CKV_OpenAPI_20 #5302

merged 2 commits into from
Jul 9, 2023

Conversation

tsmithv11
Copy link
Collaborator

@tsmithv11 tsmithv11 commented Jul 6, 2023

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Checks that HTTP is used before checking if an API key is sent over cleartext

Fixes #5300

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@tsmithv11 tsmithv11 temporarily deployed to scan-security July 7, 2023 04:41 — with GitHub Actions Inactive
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆

@gruebel gruebel merged commit ff8cec7 into main Jul 9, 2023
32 checks passed
@gruebel gruebel deleted the fix-openapi20 branch July 9, 2023 13:59
@ziggythehamster
Copy link
Contributor

I’m mobile so can’t make a ticket very easily but I noticed two small issues:

  • typo: you wrote wp but meant ws for WebSocket
  • none of the tests actually try a ws:// url

@ziggythehamster
Copy link
Contributor

Oh and I guess a third thing, OpenAPI 3.0 lets ws:// slip through where OpenAPI 2.0 would reject it if the correct scheme were listed.

@tsmithv11
Copy link
Collaborator Author

@ziggythehamster thanks for the review! I fixed those three here: #5317 Can you take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CKV_OPENAPI_20 incorrectly flags API keys via HTTPS
4 participants