Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(secrets): Improve the entropy keyword combinator secret scanner #5307

Merged
merged 4 commits into from
Jul 9, 2023

Conversation

ChanochShayner
Copy link
Contributor

@ChanochShayner ChanochShayner commented Jul 9, 2023

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Improve the entropy keyword combinator secret scanner.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ChanochShayner ChanochShayner temporarily deployed to scan-security July 9, 2023 12:17 — with GitHub Actions Inactive
@ChanochShayner ChanochShayner temporarily deployed to scan-security July 9, 2023 12:27 — with GitHub Actions Inactive
Copy link
Contributor

@lirshindalman lirshindalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! 🚀

Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍻

@gruebel gruebel merged commit 1bcae69 into main Jul 9, 2023
36 checks passed
@gruebel gruebel deleted the adjust-secrets-entropy-scanner branch July 9, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants