Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(terraform): fix ordering issue in CKV_AWS_358 #5425

Merged
merged 1 commit into from
Aug 13, 2023

Conversation

gruebel
Copy link
Contributor

@gruebel gruebel commented Aug 9, 2023

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

  • super strange issue, the exact same data block passes in the tests, but not when scanned on its own, that's why I didn't add a new test for it

Fixes #5423

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gruebel gruebel temporarily deployed to scan-security August 9, 2023 10:14 — with GitHub Actions Inactive
@gruebel gruebel merged commit 5935ed6 into main Aug 13, 2023
34 checks passed
@gruebel gruebel deleted the fix-github-oidc-check branch August 13, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CKV_AWS_358] - false alarm triggered even when GH Organisation is specified
3 participants