Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sca): update spdx-tools dep to version 0.8.0 and lower bound it #5431

Merged
merged 3 commits into from
Aug 13, 2023
Merged

feat(sca): update spdx-tools dep to version 0.8.0 and lower bound it #5431

merged 3 commits into from
Aug 13, 2023

Conversation

gruebel
Copy link
Contributor

@gruebel gruebel commented Aug 11, 2023

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

  • updated the code to work with the latest version 0.8.0, which changed quite a lot.
  • the Package class is not hashable anymore, therefore I created an internal set with cache entries to check, if it was added already or not

Fixes #5428

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gruebel gruebel temporarily deployed to scan-security August 11, 2023 22:18 — with GitHub Actions Inactive
@gruebel gruebel temporarily deployed to scan-security August 12, 2023 09:59 — with GitHub Actions Inactive
Saarett
Saarett approved these changes Aug 13, 2023
View reviewed changes
Copy link
Contributor

@Saarett Saarett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎖️

@gruebel gruebel temporarily deployed to scan-security August 13, 2023 17:15 — with GitHub Actions Inactive
@gruebel gruebel merged commit fb3b319 into main Aug 13, 2023
34 checks passed
@gruebel gruebel deleted the update-spdx branch August 13, 2023 17:35
gruebel added a commit to gruebel/checkov that referenced this pull request Aug 13, 2023
@gruebel @actions-user
feat(sca): update spdx-tools dep to version 0.8.0 and lower bound it (b…
85e39db 
…ridgecrewio#5431)

* update spdx to version 0.8.0 and lower bound it

* add test

* upper bound spdx to 0.9.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdamDev AdamDev AdamDev approved these changes

@Saarett Saarett Saarett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for spdx-tools >= 0.8
3 participants
@gruebel @AdamDev @Saarett