Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(terraform): Add __address__ field on vertices even if render_variables is set to False #5434

Merged
merged 1 commit into from
Aug 13, 2023
Merged

feat(terraform): Add __address__ field on vertices even if render_variables is set to False #5434

merged 1 commit into from
Aug 13, 2023

Conversation

bo156
Copy link
Contributor

@bo156 bo156 commented Aug 13, 2023

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Fixed a bug in which the __address__ field was only calculated on terraform vertices if render_variables is set to True.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bo156 bo156 temporarily deployed to scan-security August 13, 2023 11:20 — with GitHub Actions Inactive
@bo156 bo156 merged commit 180f17a into main Aug 13, 2023
34 checks passed
@bo156 bo156 deleted the bugfix/calculate-address-without-dep-on-variable-rendering branch August 13, 2023 11:49
ChanochShayner pushed a commit that referenced this pull request Aug 13, 2023
@bo156 @actions-user
feat(terraform): Add __address__ field on vertices even if render_var…
65dbeb1 
…iables is set to False (#5434)

Made sure we calculate __address__ field on terraform vertices even if render_variables is set to False
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omryMen omryMen omryMen approved these changes

@ChanochShayner ChanochShayner ChanochShayner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bo156 @omryMen @ChanochShayner