Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(general): add policy name and guidelines to CSV output #6082

Merged
merged 4 commits into from
Mar 11, 2024
Merged

feat(general): add policy name and guidelines to CSV output #6082

merged 4 commits into from
Mar 11, 2024

Conversation

mikeurbanski1
Copy link
Contributor

@mikeurbanski1 mikeurbanski1 commented Mar 11, 2024 •
edited
Loading

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Adds the policy name and guidelines (URL or custom policy guidelines) to the CSV output.

I added them as columns at the end so that it doesn't break any automations that users may use that relies on the column order.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

try-panwiac
try-panwiac approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@try-panwiac try-panwiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion to align to platform a little

checkov/common/output/csv.py Outdated Show resolved Hide resolved
checkov/common/output/csv.py Outdated Show resolved Hide resolved
checkov/common/output/csv.py Outdated Show resolved Hide resolved
@mikeurbanski1 mikeurbanski1 merged commit 458d526 into main Mar 11, 2024
43 of 45 checks passed
@mikeurbanski1 mikeurbanski1 deleted the csv-output-check-title-guidelines branch March 11, 2024 19:34
cawilson pushed a commit to cawilson/checkov that referenced this pull request Mar 12, 2024
@mikeurbanski1 @actions-user
feat(general): add policy name and guidelines to CSV output (bridgecr…
e498137 
…ewio#6082)

* add policy name and guidelines to CSV output

* fix fields for types

* change CSV header to match platform

* fix tests for CSV header
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kartikp10 kartikp10 kartikp10 approved these changes

@tsmithv11 tsmithv11 tsmithv11 approved these changes

@try-panwiac try-panwiac try-panwiac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mikeurbanski1 @kartikp10 @tsmithv11 @try-panwiac