Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(terraform): add fix for when tf_def is a string #6121

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

maxamel
Copy link
Contributor

@maxamel maxamel commented Mar 25, 2024

This PR adds a fix for the _connect_module_provider method, for when tf_def item is a string and we first need to convert it to TFModule and then the flow shall continue as usual.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@SteveVaknin SteveVaknin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@maxamel maxamel merged commit d1c3f1f into main Mar 26, 2024
41 checks passed
@maxamel maxamel deleted the fix_error__connect_module_provider branch March 26, 2024 08:40
losisin pushed a commit to ignite-analytics/checkov that referenced this pull request Mar 26, 2024
add fix for when tf_def is a string

Co-authored-by: Max Amelchenko <mamelchenko@paloaltonetworks.com>
harryzcy pushed a commit to harryzcy/checkov that referenced this pull request Mar 26, 2024
add fix for when tf_def is a string

Co-authored-by: Max Amelchenko <mamelchenko@paloaltonetworks.com>
harryzcy pushed a commit to harryzcy/checkov that referenced this pull request Mar 26, 2024
add fix for when tf_def is a string

Co-authored-by: Max Amelchenko <mamelchenko@paloaltonetworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants