Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(terraform): support s3 bucket name for references in graph #6134

Merged
merged 12 commits into from Apr 3, 2024
Merged

feat(terraform): support s3 bucket name for references in graph #6134

merged 12 commits into from Apr 3, 2024

Conversation

SteveVaknin
Copy link
Contributor

@SteveVaknin SteveVaknin commented Apr 1, 2024 •
edited

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

  • Support S3 bucket name for creating graph references

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

YaaraVerner
YaaraVerner reviewed Apr 1, 2024
View reviewed changes
Copy link
Contributor

@YaaraVerner YaaraVerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! can you please add UT?
also, I'm not sure if we will catch connections with multiple hops, for example - local that refer to variable

checkov/terraform/graph_builder/local_graph.py Outdated Show resolved Hide resolved
checkov/terraform/graph_builder/local_graph.py Outdated Show resolved Hide resolved
checkov/terraform/graph_builder/local_graph.py Show resolved Hide resolved
@SteveVaknin SteveVaknin merged commit 3caa971 into main Apr 3, 2024
39 of 41 checks passed
@SteveVaknin SteveVaknin deleted the steve/feat/bucket-name-ref branch April 3, 2024 10:28
pull bot pushed a commit to tooniez/checkov that referenced this pull request Apr 3, 2024
@SteveVaknin @actions-user
feat(terraform): support s3 bucket name for references in graph (brid…
178fc1f 
…gecrewio#6134)

* feature(terraform): support s3 bucket name for references

* remove commented block

* add comments and improve naming

* add test case

* fix array update

* fix mypy issue

* add test case, support locals, discard for non resource types

* remove env var

* add none validation

* resolve mypy issue in unrelated file

* add typedDict for better typing

---------

Co-authored-by: Steve Vaknin <svaknin@paloaltonetworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YaaraVerner YaaraVerner YaaraVerner left review comments

@maxamel maxamel maxamel approved these changes

@bo156 bo156 bo156 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SteveVaknin @maxamel @bo156 @YaaraVerner