Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sast): CDK TS policies p3 #6157

Merged
merged 29 commits into from Apr 10, 2024
Merged

feat(sast): CDK TS policies p3 #6157

merged 29 commits into from Apr 10, 2024

Conversation

tronxd
Copy link
Contributor

@tronxd tronxd commented Apr 10, 2024

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

added the following TS CDK policies:

EC2PublicIP
ECRImageScanning
ECRImmutableTags
ECRRepositoryEncrypted
ECSClusterContainerInsights
ECSTaskDefinitionEFSVolumeEncryption
EFSEncryptionEnabled
EKSSecretsEncryption
ELBAccessLogs
ELBv2AccessLogs
ElasticacheReplicationGroupEncryptionAtRest
ElasticacheReplicationGroupEncryptionAtTransit
ElasticacheReplicationGroupEncryptionAtTransitAuthToken
ElasticsearchDomainEnforceHTTPS
ElasticsearchDomainLogging

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

New/Edited policies (Delete if not relevant)

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@achiar99 achiar99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to change all the - new service.Func() to new $AWS.Func()

@tronxd tronxd merged commit 4bc909f into main Apr 10, 2024
41 checks passed
@tronxd tronxd deleted the cdk-ts-3 branch April 10, 2024 10:08
pull bot pushed a commit to tooniez/checkov that referenced this pull request Apr 10, 2024
* EC2PublicIP

* ECRImageScanning and ECRImmutableTags

* ECRReposistoryEncrypted

* ECSClusterContainerInsights

* ECSTaskDefinitionEFSVolumeEncryption

* EFSEncryptionEnabled

* EKSSecretsEncryption

* ELB Access logs

* ElasticacheReplicationGroup

* ElasticsearchDomain

* rename aws service

* integration tests

* EC2PublicIP

* ECRImageScanning and ECRImmutableTags

* ECRReposistoryEncrypted

* ECSClusterContainerInsights

* ECSTaskDefinitionEFSVolumeEncryption

* EFSEncryptionEnabled

* EKSSecretsEncryption

* ELB Access logs

* ElasticacheReplicationGroup

* ElasticsearchDomain

* rename aws service

* integration tests

* integration tests

* remove lang

* lint

* fix args
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants