Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(terraform): Fix conditional expression evaluation logic with compare #6160

Merged
merged 2 commits into from Apr 10, 2024
Merged

fix(terraform): Fix conditional expression evaluation logic with compare #6160

merged 2 commits into from Apr 10, 2024

Conversation

SteveVaknin
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

  • Use compare_evaluate for conditional expression condition
  • Cover with test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@SteveVaknin SteveVaknin merged commit 1b0beb2 into main Apr 10, 2024
41 checks passed
@SteveVaknin SteveVaknin deleted the steve/fix/bool-str-rendering branch April 10, 2024 13:18
pull bot pushed a commit to tooniez/checkov that referenced this pull request Apr 10, 2024
@SteveVaknin @actions-user
fix(terraform): Fix conditional expression evaluation logic with comp…
2a9defb 
…are (bridgecrewio#6160)

* fix(terraform): Fix conditional expression evaluation logic with compare

* filter out None before conversion

---------

Co-authored-by: Steve Vaknin <svaknin@paloaltonetworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bo156 bo156 bo156 approved these changes

@lirshindalman lirshindalman lirshindalman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SteveVaknin @bo156 @lirshindalman