Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(terraform): Fixed flaky test for CKV_AWS_356 #6162

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

bo156
Copy link
Contributor

@bo156 bo156 commented Apr 10, 2024

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Added setUp function to clear the cache before the test for CKV_AWS_356 as the cloudsplaining package uses a cache on the class level, making the test fail occasionally because it actually uses something wrong from the cache.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bo156 bo156 force-pushed the bugfix/fix-flaky-test-for-ckv-aws-356 branch from ae5c5a4 to acf284b Compare April 10, 2024 14:31
@bo156 bo156 merged commit cbfe283 into main Apr 10, 2024
48 checks passed
@bo156 bo156 deleted the bugfix/fix-flaky-test-for-ckv-aws-356 branch April 10, 2024 15:34
pull bot pushed a commit to tooniez/checkov that referenced this pull request Apr 10, 2024
Added setUp function to clear the cache before the test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants