Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sca): using the new api license/get-licenses-violations instead of packages/get-licenses-violations (which is deprecated) #6174

Merged
merged 1 commit into from Apr 16, 2024
Merged

feat(sca): using the new api license/get-licenses-violations instead of packages/get-licenses-violations (which is deprecated) #6174

merged 1 commit into from Apr 16, 2024

Conversation

itai1357
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

New/Edited policies (Delete if not relevant)

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

using the new api license/get-licenses-violations instead of packages…
377656d 
…/get-licenses-violations (which is deprecated)
@itai1357 itai1357 merged commit de1f669 into main Apr 16, 2024
37 of 38 checks passed
@itai1357 itai1357 deleted the itai-new-api branch April 16, 2024 08:07
itai1357 pushed a commit that referenced this pull request Apr 16, 2024
Revert "feat(sca): using the new api license/get-licenses-violations …
d6a56ca 
…instead of packages/get-licenses-violations (which is deprecated) (#6174)"

This reverts commit de1f669.
tsmithv11 pushed a commit that referenced this pull request Apr 16, 2024
@itai1357 @actions-user
feat(sca): using the new api license/get-licenses-violations instead …
5520331 
…of packages/get-licenses-violations (which is deprecated) (#6174)

using the new api license/get-licenses-violations instead of packages/get-licenses-violations (which is deprecated)

Co-authored-by: ipeleg <ipeleg@paloaltonetworks.com>
AdamDev pushed a commit that referenced this pull request Apr 16, 2024
@itai1357
fix(sca): Revert "feat(sca): using the new api license/get-licenses-v…
db6f7fe 
…iolations … (#6176)

Revert "feat(sca): using the new api license/get-licenses-violations instead of packages/get-licenses-violations (which is deprecated) (#6174)"

This reverts commit de1f669.

Co-authored-by: ipeleg <ipeleg@paloaltonetworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdamDev AdamDev AdamDev approved these changes

@MaryArmaly MaryArmaly MaryArmaly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@itai1357 @AdamDev @MaryArmaly