Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(terraform): add check for tf module versioned tag #6213

Merged
merged 3 commits into from
May 13, 2024

Conversation

mikeurbanski1
Copy link
Contributor

@mikeurbanski1 mikeurbanski1 commented Apr 25, 2024

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Adds a more lenient version of CKV_TF_1

Fixes # (issue)

New/Edited policies (Delete if not relevant)

Description

CKV_TF_1 is the best and most secure way to define a module. However, it is cumbersome, and a reasonable middle ground is to specify a ref that is a versioned tag. This is at least more secure than a branch. This check ensures that the ref at least looks like a version. It also passes if CKV_TF_1 passes.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Collaborator

@tsmithv11 tsmithv11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥂

@mikeurbanski1 mikeurbanski1 merged commit 5b51070 into main May 13, 2024
44 of 45 checks passed
@mikeurbanski1 mikeurbanski1 deleted the add-tf-module-tag-check branch May 13, 2024 15:00
@X-Guardian
Copy link

This introduces check CKV_TF_2

(added so that web searches for CKV_TF_2 will pick up this PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants