feat(arm): AppServiceJavaVersion & FunctionAppsEnableAuthentication #6243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaraWeinberg1234
had a problem deploying
to
scan-security
GitHub Actions
Failure
| def __init__(self): | ||
| name = "Ensure that 'Java version' is the latest, if used to run the web app" | ||
| id = "CKV_AZURE_83" | ||
| supported_resources = ['Microsoft.Web/sites'] |
There was a problem hiding this comment.
Please use a tuple instead of a list.
| name = "Ensure that 'Java version' is the latest, if used to run the web app" | ||
| id = "CKV_AZURE_83" | ||
| supported_resources = ['Microsoft.Web/sites'] | ||
| categories = [CheckCategories.GENERAL_SECURITY] |
There was a problem hiding this comment.
Please use a tuple instead of a list.
| return "site_config/java_version" | ||
|
|
||
| def get_expected_value(self): | ||
| return '11' |
There was a problem hiding this comment.
@tsmithv11 Should it still be 11?
(In TF is 11)
There was a problem hiding this comment.
It looks like it should be 17 (https://learn.microsoft.com/en-us/azure/app-service/language-support-policy?tabs=linux#jdk-versions-and-maintenance). That TF resource in the TF policy is deprecated which is why it caps out at 11. The new one is 17 (https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/linux_web_app#java_version)
| @@ -0,0 +1,82 @@ | |||
| # | |||
There was a problem hiding this comment.
Please remove the commented code.
ChanochShayner
changed the title
ChanochShayner
changed the title
This was referenced May 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Adds a test
Description
Added a test that checks if a certain field exists under a certain value and checks if the field is equal to a certain value
Fix
How does someone fix the issue in code and/or in runtime?
Checklist: