Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sast): add ts checks to python pack #6261

Merged
merged 4 commits into from
May 6, 2024
Merged

Conversation

achiar99
Copy link
Contributor

@achiar99 achiar99 commented May 6, 2024

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

New/Edited policies (Delete if not relevant)

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@pazbechor pazbechor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finally

@achiar99 achiar99 merged commit 5864eca into main May 6, 2024
37 of 38 checks passed
@achiar99 achiar99 deleted the add-ts-checks-to-package branch May 6, 2024 14:49
tronxd pushed a commit that referenced this pull request May 6, 2024
* add ts checks to python pack

* fix tests
achiar99 added a commit that referenced this pull request May 7, 2024
* enable cdk ts integraion test

* unskip and add missing tests

* unskip more tests

* .

* add fixture

* fix

* .

* .

* .

* ?

* ???

* .

* .

* .

* .

* .

* .

* ?

* feat(sast): run all cdk integration test (#6256)

* run all cdk

* fix

* fix

* lint

* ?

* add env

* print

* print

* print

* remove prints

* fuck u

* print

* print

* print

* .

* .

* feat(sast): add ts checks to python pack (#6261)

* add ts checks to python pack

* fix tests

* mark not implemented

* fix some tests

* fix

* fix

* ץ

* lint

---------

Co-authored-by: Naor David <nadavid@paloaltonetworks.com>
Co-authored-by: naorda <tronxd@users.noreply.github.com>
tehila86127 pushed a commit to tehila86127/checkov that referenced this pull request May 7, 2024
* enable cdk ts integraion test

* unskip and add missing tests

* unskip more tests

* .

* add fixture

* fix

* .

* .

* .

* ?

* ???

* .

* .

* .

* .

* .

* .

* ?

* feat(sast): run all cdk integration test (bridgecrewio#6256)

* run all cdk

* fix

* fix

* lint

* ?

* add env

* print

* print

* print

* remove prints

* fuck u

* print

* print

* print

* .

* .

* feat(sast): add ts checks to python pack (bridgecrewio#6261)

* add ts checks to python pack

* fix tests

* mark not implemented

* fix some tests

* fix

* fix

* ץ

* lint

---------

Co-authored-by: Naor David <nadavid@paloaltonetworks.com>
Co-authored-by: naorda <tronxd@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants