Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(terraform): handle module source tag ref when it is not the first parameter #6314

Merged
merged 5 commits into from
May 17, 2024
Merged

fix(terraform): handle module source tag ref when it is not the first parameter #6314

merged 5 commits into from
May 17, 2024

Conversation

mikeurbanski1
Copy link
Contributor

@mikeurbanski1 mikeurbanski1 commented May 16, 2024 •
edited

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Fixes #6308

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@mikeurbanski1 mikeurbanski1 merged commit f1120c0 into main May 17, 2024
37 of 38 checks passed
@mikeurbanski1 mikeurbanski1 deleted the fix-ckf-tf-2 branch May 17, 2024 17:41
boring-repos bot pushed a commit to harryzcy/checkov that referenced this pull request May 18, 2024
@mikeurbanski1 @achiar99 @actions-user
fix(terraform): handle module source tag ref when it is not the first…
ee7b487 
… parameter (bridgecrewio#6314)

handle ref when it is not the first parameter

Co-authored-by: achiar99 <34912231+achiar99@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsmithv11 tsmithv11 tsmithv11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False positive on CKV_TF_2 using shallow clone
3 participants
@mikeurbanski1 @tsmithv11 @achiar99