feat(arm): add CKV_AZURE_86 to check resorce is a ContainerRegistry with tier "Standard" #6336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rutiNalenger
had a problem deploying
to
scan-security
GitHub Actions
Failure
Comment on lines
19
to
21
| tier = properties.get("tier") | ||
|
|
||
| resourceType = properties.get("resourceType") |
There was a problem hiding this comment.
I don't see tier and resourceType fields in Microsoft.ContainerRegistry/registries
Probably this is not the resource type.
|
I dont find the right resource type, how can Iknow it?
בתאריך יום ג׳, 21 במאי 2024 ב-12:17 מאת ChanochShayner <
***@***.***>:
… ***@***.**** commented on this pull request.
------------------------------
In checkov/arm/checks/resource/AzureDefenderOnContainerRegistry.py
<#6336 (comment)>
:
> + tier = properties.get("tier")
+
+ resourceType = properties.get("resourceType")
I don't see tier and resourceType fields in
Microsoft.ContainerRegistry/registries
Probably this is not the resource type.
—
Reply to this email directly, view it on GitHub
<#6336 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BD7L7SH6XPVKGZKNZ3XRHILZDMGK7AVCNFSM6AAAAABIBD27B6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANRYGAZTIMZRGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
rutiNalenger
requested a deployment
to
scan-security
GitHub Actions
Waiting
rutiNalenger
requested a deployment
to
scan-security
GitHub Actions
Waiting
rutiNalenger
requested a deployment
to
scan-security
GitHub Actions
Waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
The function checks if a specific resource is a ContainerRegistry with tier "Standard". If so, it returns a failure result; otherwise, it returns a success result.
New/Edited policies (Delete if not relevant)
Description
Include a description of what makes it a violation and any relevant external links.
Fix
How does someone fix the issue in code and/or in runtime?
Checklist: