feat(arm): KeyVaultDisablesPublicNetworkAccess #6342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esterKoren
had a problem deploying
to
scan-security
GitHub Actions
Failure
ChanochShayner
approved these changes
May 21, 2024
| return "publicNetworkAccess" | ||
|
|
||
| def get_expected_value(self) -> str: | ||
| return "Disabled" |
There was a problem hiding this comment.
Suggested change
| return "Disabled" | |
| return "disabled" |
esterKoren
had a problem deploying
to
scan-security
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
We converted the check KeyVaultDisablesPublicNetworkAccess from TEerraform language to ARM so that it also works on resources that are defined in ARM.
Fixes # (issue)
Description
Ensure that Azure Key Vault disables public network accessEnsure that Azure Key Vault disables public network access.
Fix
Update the NetworkInterfaceEnableIPForwarding class to include missing return type annotations for its methods.
Checklist: