-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(arm): AzureServiceFabricClusterProtectionLevel #6366
feat(arm): AzureServiceFabricClusterProtectionLevel #6366
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Please fix the failing jobs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
if not isinstance(properties, dict): | ||
self.evaluated_keys = ['properties'] | ||
return CheckResult.FAILED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe properties is required, so unnecessary, but not wrong :)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
adds a AzureServiceFabricClusterProtectionLevel
Description
The scan_resource_conf function checks whether a certain resource in the Azure environment meets certain conditions related to security, and returns a test result accordingly.
Fix
How does someone fix the issue in code and/or in runtime?
Checklist: