Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(azure): drop support for dotnet v7.0 #6383

Merged
merged 1 commit into from
Jun 4, 2024
Merged

feat(azure): drop support for dotnet v7.0 #6383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion checkov/arm/checks/resource/AppServiceDotnetFrameworkVersion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ def get_inspected_key(self) -> str:
return "properties/netFrameworkVersion"

def get_expected_value(self) -> str:
return "v7.0"
return "v8.0"


check = AppServiceDotnetFrameworkVersion()
4 changes: 2 additions & 2 deletions checkov/terraform/checks/resource/azure/AppServiceDotnetFrameworkVersion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,14 @@ def scan_resource_conf(self, conf) -> CheckResult:
if site_config.get('application_stack') and isinstance(site_config.get('application_stack'), list):
stack = site_config.get('application_stack')[0]
if stack.get('dotnet_version') and isinstance(stack.get('dotnet_version'), list):
if stack.get('dotnet_version')[0] == "v7.0":
if stack.get('dotnet_version')[0] == "v8.0":
return CheckResult.PASSED
return CheckResult.FAILED

return CheckResult.UNKNOWN

def get_expected_values(self) -> List[str]:
return ["v6.0", "v7.0"]
return ["v6.0", "v8.0"]
maxamel marked this conversation as resolved.
Show resolved Hide resolved


check = AppServiceDotnetFrameworkVersion()
2 changes: 1 addition & 1 deletion tests/arm/checks/resource/example_AppServiceDotnetFrameworkVersion/passed.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@
"index.php",
"hostingstart.html"
],
"netFrameworkVersion": "v7.0",
"netFrameworkVersion": "v8.0",
"phpVersion": "5.6",
"requestTracingEnabled": true,
"requestTracingExpirationTime": "9999-12-31T23:59:00Z",
Expand Down
2 changes: 1 addition & 1 deletion tests/terraform/checks/resource/azure/example_AppServiceDotnetFrameworkVersion/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ resource "azurerm_windows_web_app" "pass" {
http2_enabled = true
health_check_path = var.health_check_path
application_stack {
dotnet_version = "v7.0"
dotnet_version = "v8.0"
}
}

Expand Down
Loading