Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(terraform): add fix for ckv_aws_300 #6404

Merged
merged 3 commits into from
Jun 6, 2024
Merged

feat(terraform): add fix for ckv_aws_300 #6404

merged 3 commits into from
Jun 6, 2024

Conversation

maxamel
Copy link
Contributor

@maxamel maxamel commented Jun 5, 2024 •
edited
Loading

This PR fixes the CKV_AWS_300 check by taking into account the filterings available for the S3 lifecycle directive.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@maxamel maxamel changed the title Draft: feat(terraform): add fix for ckv_aws_300 feat(terraform): add fix for ckv_aws_300 Jun 5, 2024
@maxamel maxamel requested a review from bo156 June 5, 2024 14:06
@bo156 bo156 merged commit a650b49 into main Jun 6, 2024
41 checks passed
@bo156 bo156 deleted the fix_ckv_aws_300 branch June 6, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bo156 bo156 bo156 approved these changes

@lirshindalman lirshindalman lirshindalman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maxamel @bo156 @lirshindalman