Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend to support config.yml files for SLS #362

Merged
merged 2 commits into from
Apr 30, 2023
Merged

Extend to support config.yml files for SLS #362

merged 2 commits into from
Apr 30, 2023

Conversation

nimrodkor
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Removed dependency on goserverless, as we need a much leaner parsing mechanism

@nimrodkor nimrodkor marked this pull request as ready for review April 30, 2023 11:20
ChanochShayner
ChanochShayner approved these changes Apr 30, 2023
View reviewed changes
Copy link
Contributor

@ChanochShayner ChanochShayner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@nimrodkor nimrodkor merged commit c532581 into main Apr 30, 2023
8 checks passed
@nimrodkor nimrodkor deleted the handle_config_yml_sls branch April 30, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rotemavni rotemavni rotemavni approved these changes

@ChanochShayner ChanochShayner ChanochShayner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nimrodkor @rotemavni @ChanochShayner