Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove azurerm resources that don't contain tags anymore #371

Merged
merged 1 commit into from
May 23, 2023

Conversation

lonegunmanb
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

I've checked azurerm resources list in tf_taggable.go file, we have the following resources that have been removed in AzureRM provider 3.0:

  • azurerm_api_management_property
  • azurerm_data_lake_analytics_account
  • azurerm_devspace_controller
  • azurerm_hdinsight_ml_services_cluster
  • azurerm_hdinsight_rserver_cluster
  • azurerm_hdinsight_storm_cluster
  • azurerm_service_fabric_mesh_application
  • azurerm_service_fabric_mesh_local_network
  • azurerm_service_fabric_mesh_secret
  • azurerm_service_fabric_mesh_secret_value

We also have the following resources that don't contain tags anymore:

  • azurerm_backup_policy_file_share
  • azurerm_backup_policy_vm
  • azurerm_backup_protected_vm
  • azurerm_log_analytics_linked_service
  • azurerm_log_analytics_storage_insights
  • azurerm_netapp_snapshot

This pr has removed the resources that don't contain tags anymore, otherwise when users use yor along with the latest provider, yor would try to generate tags on these resources and cause error.

Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 🍻

@gruebel gruebel merged commit 17fcee5 into bridgecrewio:main May 23, 2023
7 checks passed
@lonegunmanb lonegunmanb deleted the obsolete-resource branch May 23, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants