Add Markdown support to convert == / :: to <mark>
#551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://bridgetown-api-pr-551.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c9tuge4gqg4dk7k8c4ig. |
|
Your Render PR Server URL is https://bridgetown-beta-pr-551.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c9tugekgqg4dk7k8c4m0. |
|
Can't do that because the GFM initializer hardcodes all the block and span definitions. 🤷 |
|
Was just starting to build a regex to do this so 🎉 Great addition! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many Markdown editors allow you to highlight text with
::double colons::or with==double equals==. I've grown accustomed to this myself in various writing contexts. Because of that, it's frustrating to have to switch gears in Bridgetown.mdfiles and add<mark>tags everywhere instead.This PR patches Kramdown's GFM parser (our default) to add support for both those delimiters. So for example:
becomes
The
kramdown: mark_highlightingYAML config option can be set tofalseto disable this new feature if for some reason it's a breaking change for existing websites.