Fix purgecss plugin crashing when using scss #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using SASS, the manifest key is `index.scss` instead of `index.css`, raising `undefined method 'split' for nil:NilClass` on line 24.
|
Looks good to me! Thanks @goulvench |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using SASS, the manifest key is
index.scssinstead ofindex.css, raisingundefined method 'split' for nil:NilClass.The crash happens at line 24 (
css_file = manifest["styles/index.css"].split("/").last).This is a 馃悰 bug fix.
I haven't found tests for this plugin, let me know if there are that I can tweak to exercise this condition.
Summary
When a project uses scss instead of plain css, the expected manifest key is slightly different, crashing the
purgecssplugin to crash. By reading eitherindex.cssorindex.scssthe plugin handles both cases without erroring out.