Eager load to make DEFAULTS deterministic #776
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a 馃悰 bug fix.
Summary
Configuration::DEFAULTS
usesDir.pwd
to determine the root directory for the configuration. This means that lazy loading the file usingautoload
makes the root path for configuration non-deterministic depending on the directory location the first time you try to useBridgetown::Configuration
.This has a knock-on effect of making tests fail nondeterministically.
By eager loading the configuration file, we can reduce this nondeterminism by ensuring the value is set the same way every time.
Context
This can be reproduced with the following on 7ecd7f6.
Reproduction
Run this on that commit, then on this commit, and see that there's no longer a leak in the test. With this change, I think we can remove the
SEED=2345
inscript/test
and go back to using random testing.