Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logs and console for Ruby 3.3 #834

Merged
merged 8 commits into from Jan 2, 2024
Merged

Fix logs and console for Ruby 3.3 #834

merged 8 commits into from Jan 2, 2024

Conversation

jaredcwhite
Copy link
Member

Resolves #833

@render Render
Copy link

render bot commented Dec 31, 2023

Your Render PR Server URL is https://bridgetown-api-pr-834.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-cm8f2kud3nmc73fuenn0.

@render Render
Copy link

render bot commented Dec 31, 2023

Your Render PR Server URL is https://bridgetown-beta-pr-834.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-cm8f2l6d3nmc73fuenr0.

@jaredcwhite
Copy link
Member Author

Ran into a problem trying to get CI to work with Ruby 3.3 — seems there's no prebuilt extension available for Nokolexbor yet.

@jaredcwhite jaredcwhite added the high priority This should get addressed as soon as possible. label Dec 31, 2023
davidstosik
davidstosik reviewed Jan 1, 2024
View reviewed changes
bridgetown-core/lib/bridgetown-core/log_writer.rb Outdated
msg.to_s
end
def initialize
super $stdout, formatter: proc { |_, _, _, msg| msg.to_s }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@jaredcwhite jaredcwhite merged commit bd75129 into main Jan 2, 2024
4 checks passed
@jaredcwhite jaredcwhite deleted the fix-logs-console-ruby-3-3 branch January 2, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidstosik davidstosik davidstosik left review comments

Assignees
No one assigned
Labels
high priority This should get addressed as soon as possible.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LogWriter not compatible with the Ruby 3.3 implementation of Logger
2 participants
@jaredcwhite @davidstosik