Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI for Documentation and tests #10

Merged
merged 6 commits into from May 25, 2021
Merged

CI for Documentation and tests #10

merged 6 commits into from May 25, 2021

Conversation

briederer
Copy link
Owner

@briederer briederer commented May 25, 2021 •
edited

This should add the needed CI for creating docs on push/pull requests to master as discussed in #5.

@briederer briederer added documentation Improvements or additions to documentation workflow For internal workflow and CI labels May 25, 2021
@briederer briederer changed the title CI for Documentation and tests [WIP] CI for Documentation and tests May 25, 2021
@fzierler
Copy link
Collaborator

Nice! I think it is sufficient if we only test on 1.6 and nightly since 1.5 is no longer maintained and 1.0.5 LTS will soon (at the time of the 1.7 release in about 2-3 months) be replaced by 1.6 as LTS.

@briederer
Copy link
Owner Author

When the checks have finished I guess everything works and it is ready to be merged (this time with squash/merge 😉)
I also added a workflow to the gh-pages branch which should be executed when merging the PR to master and clean the PR-preview webpages.

@briederer briederer changed the title [WIP] CI for Documentation and tests CI for Documentation and tests May 25, 2021
@briederer
Copy link
Owner Author

Nice! I think it is sufficient if we only test on 1.6 and nightly since 1.5 is no longer maintained and 1.0.5 LTS will soon (at the time of the 1.7 release in about 2-3 months) be replaced by 1.6 as LTS.

I would keep it as it is for now and with the release of 1.7 and the change of the LTS also change the CI.

@briederer briederer mentioned this pull request May 25, 2021
Open
5 tasks
@fzierler
Copy link
Collaborator

Looks good to me. I'll merge and look at code coverage in a separate PR.

@fzierler fzierler merged commit 28c0b54 into master May 25, 2021
@briederer briederer deleted the documentation_ci branch May 25, 2021 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation workflow For internal workflow and CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@briederer @fzierler