Add use-context command #96

rafiramadhana · 2023-09-17T12:40:07Z

Why this matters

Resolves #89

Solution

Add command use-context to use the selected current context.

How to test it

Run the e2e.yml.

Note to reviewers

rafiramadhana · 2023-09-17T12:42:50Z

.github/workflows/e2e.yml

+          # fails if command succeeds
+          ! layerform config select-context test-does-not-exist # context does not exist
+
+          layerform config set-context test-local -t local --dir test && layerform config select-context test-local


I'm still wondering what is the default layerform/configurations.yml file in our CI/CD testing env.

As the mitigation to ensure that a config exists, I do set-context first to create a config.

Well, it is the last one that run in the previous step (check line 50).
At this point, the current context is the test-local, your set-context ends up being a no-op.
What I think you should do to test is somehow check if the use-context actually works.
You can use the config get-contexts command alongside with grep for that. The selected context will have a * in it's line.
I'll make a comment with suggestions.

updated 9e15b35

vieiralucas

Hi @rafiramadhana,

Thank you so much for the contribution, overall the implementation seems correct.
I think you got confused with the name of the command, the idea was to call it use-context. Do you mind changing it? Also change the name of the file and stuff.

vieiralucas · 2023-09-17T23:08:57Z

cmd/cli/select_context.go

+			os.Exit(1)
+		}
+
+		fmt.Fprintf(os.Stdout, "Context \"%s\" selected.\n", name)


Can we change this to:

Suggested change

fmt.Fprintf(os.Stdout, "Context \"%s\" selected.\n", name)

fmt.Fprintf(os.Stdout, "Switched to context \"%s\".\n", name)

FYI I'm getting inspiration from kubectl

updated 978e3c6

vieiralucas · 2023-09-17T23:11:52Z

cmd/cli/select_context.go

+		if !ok {
+			fmt.Fprintf(
+				os.Stderr,
+				"context %s does not exist\n",


Can we change this to:

Suggested change

"context %s does not exist\n",

"no context exists with the name \"%s\".\n",

updated 978e3c6

Update e2e test of use context.

Fix typo in grep command.

rafiramadhana · 2023-09-19T01:24:24Z

@vieiralucas it looks like the configure s3 pipeline is broken

fail to get layers backend: fail to read file: fail to load layers from s3: NoCredentialProviders: no valid providers in chain. Deprecated.
	For verbose messaging see aws.Config.CredentialsChainVerboseErrors
Error: Process completed with exit code 1.

https://github.com/ergomake/layerform/actions/runs/6229934241/job/16909208767?pr=96

could this be related to my PR changes?

vieiralucas · 2023-09-19T15:56:28Z

Hi @rafiramadhana, this happens because your changes to the tests leave a context of type s3 as active. Then later commands will try to use s3 as the backend but we don't have AWS setup here in the workflows.
You can just switch the ortder of the tests you added, put the test-local as the last one.

vieiralucas · 2023-09-19T15:59:04Z

.github/workflows/e2e.yml

+          # switch context to test-local
+          layerform config use-context test-local
+          layerform config get-contexts | tee usecontext
+          grep -E '^\*\s+test-local' usecontext
+          ! grep -E '^\*\s+test-s3' usecontext
+
+          # switch context to test-s3
+          layerform config use-context test-s3
+          layerform config get-contexts | tee usecontext
+          ! grep -E '^\*\s+test-local' usecontext
+          grep -E '^\*\s+test-s3' usecontext


I think this change should "fix" the tests

Suggested change

# switch context to test-local

layerform config use-context test-local

layerform config get-contexts | tee usecontext

grep -E '^\*\s+test-local' usecontext

! grep -E '^\*\s+test-s3' usecontext

# switch context to test-s3

layerform config use-context test-s3

layerform config get-contexts | tee usecontext

! grep -E '^\*\s+test-local' usecontext

grep -E '^\*\s+test-s3' usecontext

# switch context to test-s3

layerform config use-context test-s3

layerform config get-contexts | tee usecontext

! grep -E '^\*\s+test-local' usecontext

grep -E '^\*\s+test-s3' usecontext

# switch context to test-local

layerform config use-context test-local

layerform config get-contexts | tee usecontext

grep -E '^\*\s+test-local' usecontext

! grep -E '^\*\s+test-s3' usecontext

updated 3f94a83

thanks for the pointers

vieiralucas

Awesome @rafiramadhana

Thank you so much for this <3

rafiramadhana added 2 commits September 17, 2023 19:00

Add select context

540ed40

Fix typo

89fbf7d

rafiramadhana commented Sep 17, 2023

View reviewed changes

Run make fmt

4fc2240

vieiralucas suggested changes Sep 17, 2023

View reviewed changes

rafiramadhana added 3 commits September 19, 2023 07:23

Rename to use context

978e3c6

Merge branch 'main' into 89-cmd-to-select-current-context

0a962c5

Update e2e test

9e15b35

Update e2e test of use context.

rafiramadhana force-pushed the 89-cmd-to-select-current-context branch from b41aede to 9e15b35 Compare September 19, 2023 01:19

Fix typo

3d7c8a7

Fix typo in grep command.

rafiramadhana changed the title ~~Add select context~~ Add use-context command Sep 19, 2023

vieiralucas suggested changes Sep 19, 2023

View reviewed changes

Fix broken pipeline

3f94a83

vieiralucas approved these changes Sep 20, 2023

View reviewed changes

vieiralucas merged commit 5055275 into briefercloud:main Sep 20, 2023
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add use-context command #96

Add use-context command #96

rafiramadhana commented Sep 17, 2023 •

edited

Loading

rafiramadhana Sep 17, 2023

vieiralucas Sep 17, 2023 •

edited

Loading

rafiramadhana Sep 19, 2023

vieiralucas left a comment

vieiralucas Sep 17, 2023

rafiramadhana Sep 19, 2023

vieiralucas Sep 17, 2023

rafiramadhana Sep 19, 2023

rafiramadhana commented Sep 19, 2023

vieiralucas commented Sep 19, 2023

vieiralucas Sep 19, 2023

rafiramadhana Sep 20, 2023

vieiralucas left a comment

	fmt.Fprintf(os.Stdout, "Context \"%s\" selected.\n", name)
	fmt.Fprintf(os.Stdout, "Switched to context \"%s\".\n", name)

	"context %s does not exist\n",
	"no context exists with the name \"%s\".\n",

Add use-context command #96

Add use-context command #96

Conversation

rafiramadhana commented Sep 17, 2023 • edited Loading

Why this matters

Solution

How to test it

Note to reviewers

Choose a reason for hiding this comment

vieiralucas Sep 17, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vieiralucas left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rafiramadhana commented Sep 19, 2023

vieiralucas commented Sep 19, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vieiralucas left a comment

Choose a reason for hiding this comment

rafiramadhana commented Sep 17, 2023 •

edited

Loading

vieiralucas Sep 17, 2023 •

edited

Loading