Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid Mutation of @data from external reference #51

Closed
wants to merge 3 commits into from

Conversation

kungfumike
Copy link
Contributor

return a mutable reference that allowed in memory mutation of the
@DaTa struct inside MockRedis

Spec is probably not consistent with present spec structure but
does illustrate a red/green against method. Spec might also need
be moved as it effects more then just hgetall.

This commit done on the dime of:
Simply Measured
twitter: @SimplyMeasured
web: http://www.simplymeasured.com

return a mutable reference that allowed in memory mutation of the
@DaTa struct inside MockRedis

Spec is probably not consistent with present spec structure but
does illustrate a red/green against method. Spec might also need
be moved as it effects more then just hgetall.

This commit done on the dime of:
Simply Measured
twitter: @SimplyMeasured
web: http://www.simplymeasured.com
arround. This corrals the dump call to arrays hashes and strings
@kungfumike
Copy link
Contributor Author

I can move that stuff around, sure.

Trinay is what happens when you try to type 'ternary' high on cold medicine.

I had to further correct this logic to only apply to hashes, arrays, and strings. As certian methods like sadd return 'true' which like nil also can't be duped.

I will get those specs moved around

@sectioneight's request

This commit done on the dime of:
Simply Measured
twitter: @SimplyMeasured
web: http://www.simplymeasured.com
@kungfumike
Copy link
Contributor Author

@sectioneight Moved the spec around for you, go ahead and give it another look when you have a chance. Thanks.

@ascandella
Copy link

@kungfumike Thanks! We're a little, uh... obsessive about our code style at @causes. If you don't mind, I'll squash these all into one commit, since we don't want any single point in history to have failing specs.

@ascandella
Copy link

Cherry-pick to master at a08edf7 courtesy of our Gerrit code review instance. Thanks for fixing this up!

@ascandella ascandella closed this Mar 14, 2013
@sds sds added the bug label Apr 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants