Skip to content

Commit

Permalink
Remove XML formatter
Browse files Browse the repository at this point in the history
As was mentioned in:

  #372 (comment)

...this formatter doesn't appear to be used, and is superseded by the
`Checkstyle` plugin.

Removing it allows us to remove a dependency on Nokogiri, which
significantly speeds up test runs in Travis since it does not need to be
installed.

It also removes a source of confusion, as some developers mistake it for
the `Checkstyle` plugin at first.
  • Loading branch information
sds committed May 11, 2015
1 parent cbc7047 commit c6df8d7
Show file tree
Hide file tree
Showing 6 changed files with 3 additions and 158 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@
* Load configuration file from user's home directory if one exists and no other
configuration file is specified or in the current working directory
* Improve issue reporting instructions displayed when scss-lint crashes
* Remove `XML` formatter (see the
[`Checkstyle` formatter](https://github.com/Sweetchuck/scss_lint_reporter_checkstyle)
for an XML-based alternative)

## 0.38.0

Expand Down
20 changes: 0 additions & 20 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -268,26 +268,6 @@ Outputs JSON with filenames and an array of issue objects.
}
```

### XML

Outputs XML with `<lint>`, `<file>`, and `<issue>` tags.

```bash
scss-lint --format=XML [scss-files...]
```

```xml
<?xml version="1.0" encoding="utf-8"?>
<lint>
<file name="test.css">
<issue line="2" severity="warning" reason="Prefer single quoted strings" />
<issue line="2" severity="warning" reason="Line should be indented 0 spaces, but was indented 1 spaces" />
<issue line="5" severity="warning" reason="Prefer single quoted strings" />
<issue line="6" severity="warning" reason="URLs should be enclosed in quotes" />
</file>
</lint>
```

### Plugins

There are also formatters that integrate with third-party tools which are available as plugins.
Expand Down
33 changes: 0 additions & 33 deletions lib/scss_lint/reporter/xml_reporter.rb

This file was deleted.

1 change: 0 additions & 1 deletion scss_lint.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,5 @@ Gem::Specification.new do |s|
s.add_dependency 'rainbow', '~> 2.0'
s.add_dependency 'sass', '~> 3.4.1'

s.add_development_dependency 'nokogiri', '~> 1.6.0'
s.add_development_dependency 'rspec', '~> 3.0'
end
103 changes: 0 additions & 103 deletions spec/scss_lint/reporter/xml_reporter_spec.rb

This file was deleted.

1 change: 0 additions & 1 deletion spec/spec_helper.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
require 'scss_lint'
require 'nokogiri'

Dir[File.dirname(__FILE__) + '/support/**/*.rb'].each { |f| require f }

Expand Down

0 comments on commit c6df8d7

Please sign in to comment.