This repository has been archived by the owner on Jun 1, 2022. It is now read-only.
build / release fixes #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kent Rancourt <kent.rancourt@microsoft.com>
Signed-off-by: Kent Rancourt <kent.rancourt@microsoft.com>
vdice
approved these changes
May 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small follow-up to #59
Minor formatting / style fixes on
brigade.js-- add missing semicolons and remove unused variables, for instance, and quote string literal keys in maps for clarity.Improve how git short shas are calculated during the build / release process. After working on changes similar to those in evolve the build and release process #59 on the main brigade project, I noticed something odd about the process that we were using here-- it builds off the last annotated tag (if there is one). i.e. You get
<last annotated tag>-<number of commits beyond that tag>-<git sha>and that was not what I ever intended. The new logic will never match any tag and will always fall back on using just the short sha of HEAD.