This repository has been archived by the owner on Jun 1, 2022. It is now read-only.
Feature: return proper branch reference and commit id with events #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cscheib
force-pushed
the
feature/add-git-refs
branch
from
9892a2d
to
c649b3b
Compare
Closed
…ields that I care about, update server.go to utilize these fields/values Signed-off-by: Chris Scheib <chris@scheib.io>
change image back to alpine to fix an issue with /tmp file writes update Dockerfile to put binary back in original location Signed-off-by: Chris Scheib <chris@scheib.io>
Signed-off-by: Chris Scheib <chris@scheib.io>
Signed-off-by: Chris Scheib <chris@scheib.io>
Signed-off-by: Chris Scheib <chris@scheib.io>
Signed-off-by: Chris Scheib <chris@scheib.io>
Signed-off-by: Chris Scheib <chris@scheib.io>
Signed-off-by: Chris Scheib <chris@scheib.io>
cscheib
force-pushed
the
feature/add-git-refs
branch
from
90b972b
to
dbf7fff
Compare
|
This is excellent work, thank you, @cscheib! We should also look into updating the name of the repo / gateway to keep up with Azure Pipelines name changing.. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the "Known Limitation" that previously only returned
ref: masterandcommit: HEADThis seemed to require an undue amount of effort to build as-is, so I took the liberty of updating the Makefile and Dockerfile to look more like
brigade-github-appgateway's.I've also updated the documentation accordingly.
I left these commits pretty separate in case someone wants to cherry-pick them.