Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSV output is not correct #78

Closed
keestux opened this issue Feb 29, 2016 · 1 comment
Closed

CSV output is not correct #78

keestux opened this issue Feb 29, 2016 · 1 comment
Assignees
@bright-tools
Labels
bug
Milestone
Release 0.3

Comments

@keestux
Copy link
Contributor

keestux commented Feb 29, 2016

Hi,

The generated CSV/TSV is not correct. In MetricDumper::dump there are two loops, one for the field names and one for the field values. Both loops must match for the generation of the separators.

Currently, the second loop that generates the values, only outputs separators for the fields that it outputs. And it only outputs a field value if it is relevant for the item.

You can already see the effect for item "Global". Here is an example

Name,Return points,Comment density,McCabe complexity,Modified McCabe...
Global,0.586,42,,10242,,
bright-tools added a commit that referenced this issue Feb 29, 2016
@bright-tools
Updates #78 by fixing up CSV and TSV output
4b3cef3 
Previous code didn't deal correctly with columns which are not
output on some rows (i.e. where metric did not apply to that
item type).  Update improves matters, but needs more testing
bright-tools added a commit that referenced this issue Feb 29, 2016
@bright-tools
Merge pull request #79 from bright-tools/iss78_csv_output_incorrect
da6e003 
Updates #78 by fixing up CSV and TSV output
@bright-tools bright-tools added this to the Release 0.3 milestone Feb 29, 2016
@bright-tools bright-tools self-assigned this Feb 29, 2016
@bright-tools
Copy link
Owner

Believe this to be fixed now - please let me know if you still experience any problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bright-tools bright-tools

Labels
bug
Projects
None yet
Milestone
Release 0.3
Development

No branches or pull requests
2 participants
@keestux @bright-tools