Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to unix-dgram 2.0.6 for node 18 support #235

Closed
DZDomi opened this issue Oct 18, 2022 · 1 comment
Closed

Upgrade to unix-dgram 2.0.6 for node 18 support #235

DZDomi opened this issue Oct 18, 2022 · 1 comment

Comments

@DZDomi
Copy link

DZDomi commented Oct 18, 2022

Hey,

In order to have support for node 18, the unix-dram package needs to be upgraded to 2.0.6, which came out yesterday.

Currently the build will fail with the following error message on node 18.11.0:

../../nan/nan_typedarray_contents.h:34:43: error: ‘class v8::ArrayBuffer’ has no member named ‘GetContents’
   34 |       data   = static_cast<char*>(buffer->GetContents().Data()) + byte_offset;
      |                                           ^~~~~~~~~~~
@DZDomi
Copy link
Author

DZDomi commented Oct 24, 2022

Thanks for taking the time to upgrade ❤️ , already updated and works fine 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants