-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: generator v7 #10
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
# http://editorconfig.org | ||
root = true | ||
|
||
[*] | ||
charset = utf-8 | ||
end_of_line = lf | ||
indent_style = space | ||
indent_size = 2 | ||
insert_final_newline = true | ||
trim_trailing_whitespace = true | ||
|
||
[*.md] | ||
trim_trailing_whitespace = false |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,33 @@ | ||
/node_modules/ | ||
npm-debug.log | ||
# OS | ||
Thumbs.db | ||
ehthumbs.db | ||
Desktop.ini | ||
.DS_Store | ||
._* | ||
|
||
# Editors | ||
*~ | ||
*.swp | ||
*.tmproj | ||
*.tmproject | ||
*.sublime-* | ||
.idea/ | ||
.project/ | ||
.settings/ | ||
.vscode/ | ||
|
||
# Logs | ||
logs | ||
*.log | ||
npm-debug.log* | ||
|
||
# Dependency directories | ||
bower_components/ | ||
node_modules/ | ||
|
||
# Build-related directories | ||
dist/ | ||
docs/api/ | ||
test/dist/ | ||
.eslintcache | ||
.yo-rc.json |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
# Intentionally left blank, so that npm does not ignore anything by default, | ||
# but relies on the package.json "files" array to explicitly define what ends | ||
# up in the package. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
lts/* |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,16 @@ | ||
sudo: false | ||
dist: trusty | ||
language: node_js | ||
node_js: | ||
- '8' | ||
- '6' | ||
- '4' | ||
# node version is specified using the .nvmrc file | ||
before_install: | ||
- npm install -g greenkeeper-lockfile@1 | ||
before_script: | ||
- export DISPLAY=:99.0 | ||
- sh -e /etc/init.d/xvfb start | ||
- greenkeeper-lockfile-update | ||
after_script: | ||
- greenkeeper-lockfile-upload | ||
addons: | ||
firefox: latest | ||
chrome: stable | ||
|
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
# CONTRIBUTING | ||
|
||
We welcome contributions from everyone! | ||
|
||
## Getting Started | ||
|
||
Make sure you have Node.js 4.8 or higher and npm installed. | ||
|
||
1. Fork this repository and clone your fork | ||
1. Install dependencies: `npm install` | ||
1. Run a development server: `npm start` | ||
|
||
### Making Changes | ||
|
||
Refer to the [video.js plugin conventions][conventions] for more detail on best practices and tooling for video.js plugin authorship. | ||
|
||
When you've made your changes, push your commit(s) to your fork and issue a pull request against the original repository. | ||
|
||
### Running Tests | ||
|
||
Testing is a crucial part of any software project. For all but the most trivial changes (typos, etc) test cases are expected. Tests are run in actual browsers using [Karma][karma]. | ||
|
||
- In all available and supported browsers: `npm test` | ||
- In a specific browser: `npm run test:chrome`, `npm run test:firefox`, etc. | ||
- While development server is running (`npm start`), navigate to [`http://localhost:9999/test/`][local] | ||
|
||
|
||
[karma]: http://karma-runner.github.io/ | ||
[local]: http://localhost:9999/test/ | ||
[conventions]: https://github.com/videojs/generator-videojs-plugin/blob/master/docs/conventions.md |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
Copyright Brightcove Inc | ||
|
||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,12 +12,14 @@ if (userArgs.indexOf('-h') !== -1 || userArgs.indexOf('--help') !== -1) { | |
// eslint-disable-next-line | ||
console.log('usage: pkcs7'); | ||
// eslint-disable-next-line | ||
return console.log('pkcs7 expects input on stdin and outputs to stdout'); | ||
console.log('pkcs7 expects input on stdin and outputs to stdout'); | ||
process.exit(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The linter complained about using return here, I think process.exit makes more sense. Same for the code below this. |
||
} | ||
|
||
if (userArgs.indexOf('-v') !== -1 || userArgs.indexOf('--version') !== -1) { | ||
// eslint-disable-next-line | ||
return console.log(JSON.parse(fs.readFileSync(path.join(process.cwd(), 'package.json'))).version); | ||
console.log(JSON.parse(fs.readFileSync(path.join(process.cwd(), 'package.json'))).version); | ||
process.exit(); | ||
} | ||
|
||
const data = []; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The long version of this license used to be in the repo, but all of our other projects use the short one. I think it makes sense to switch here.