Error if Flash tech is unusable #50
Conversation
| @@ -61,6 +61,13 @@ const initPlugin = function(player, options) { | |||
| const resetMonitor = function() { | |||
| window.clearTimeout(monitor); | |||
| monitor = window.setTimeout(function() { | |||
| // if using Flash then make sure its API is available | |||
| if (/swf/i.test(player.tech_.el().data) && | |||
There was a problem hiding this comment.
Can we get at this without using tech_? That's supposed to be a private property.
There was a problem hiding this comment.
Going to use player.$() instead
| let tech = player.$('.vjs-tech'); | ||
|
|
||
| // don't error if using Flash and its API is available | ||
| if (tech && tech.type === 'application/x-shockwave-flash' && tech.vjs_getProperty) { |
There was a problem hiding this comment.
shouldn't this be && !tech.vjs_getProperty?
|
I think something's still wrong with this, here's the scenario: |
| } | ||
|
|
||
| // playback isn't expected if the player is paused, shut | ||
| // down monitoring |
There was a problem hiding this comment.
I think this comment is somewhat inaccurate. Technically, you're saying "keep checking, it looks like everything is fine right now".
* Error if Flash tech is unusable * Return early if there already is an error * Added clarifying comments
No description provided.