refactor: Update to use generator v5 tooling. #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misteroneill
force-pushed
the
fix-bundling
branch
7 times, most recently
from
7cc3a2a
to
bfd6c5b
Compare
BREAKING CHANGE: Remove support for IE8. BREAKING CHANGE: Remove support for Bower.
package.json
Outdated
| "lint": "vjsstandard", | ||
| "start": "babel-node scripts/server.js", | ||
| "prestart": "npm run build", |
There was a problem hiding this comment.
Manually delete pre-start for now, I removed it from the generator, but I did not put it in vjscleanup
There was a problem hiding this comment.
vjsgenclean is no more, anyway. :)
There was a problem hiding this comment.
ahh well no pr needed then
There was a problem hiding this comment.
FWIW, it was removed from the generator because with major versions transitioning to and from Spellbook, it became really brittle and hard to maintain for too little benefit, I think.
brandonocasey
approved these changes
Aug 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Remove support for IE8.
BREAKING CHANGE: Remove support for Bower.