Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disk Collector only works in python2.6 #18

Closed
sswift opened this issue Jan 13, 2012 · 1 comment
Closed

Disk Collector only works in python2.6 #18

sswift opened this issue Jan 13, 2012 · 1 comment

Comments

@sswift
Copy link

sswift commented Jan 13, 2012

Looks like namedtuple() was used, which breaks on 2.4 installations.

[2012-01-13 09:43:19,380] [MainThread] Failed to import module: DiskSpaceCollector. Traceback (most recent call last):
File "/usr/lib/python2.4/site-packages/diamond/server.py", line 143, in load_collectors
mod = import(modname, globals(), locals(), ['*'])
File "/usr/share/diamond/collectors/Disk/DiskSpaceCollector/DiskSpaceCollector.py", line 19
name = 'root' if name == '_' else name
^
SyntaxError: invalid syntax

[2012-01-13 09:43:19,380] [MainThread] Failed to import module: disk. Traceback (most recent call last):
File "/usr/lib/python2.4/site-packages/diamond/server.py", line 143, in load_collectors
mod = import(modname, globals(), locals(), ['*'])
File "/usr/share/diamond/collectors/Disk/disk.py", line 6, in ?
from collections import namedtuple
ImportError: cannot import name namedtuple

@kormoc
Copy link
Contributor

kormoc commented Jan 13, 2012

I do plan on rewriting these collectors soon to not require the disk.py import. I'll also change them to work without the named truple.

Thanks for the report!

@kormoc kormoc closed this as completed in 038adac Jan 13, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants