Skip to content
This repository has been archived by the owner on Aug 8, 2019. It is now read-only.

Destroy button hangs if the process ignores SIGTERM #64

Open
sodabrew opened this issue Sep 24, 2014 · 4 comments
Open

Destroy button hangs if the process ignores SIGTERM #64

sodabrew opened this issue Sep 24, 2014 · 4 comments
Assignees

Comments

@sodabrew
Copy link
Collaborator

If the queue process ignores SIGTERM, it will cause a web process to hang until it receives the signal. There should be a timeout followed by a SIGKILL.

@sodabrew sodabrew self-assigned this Sep 24, 2014
@drudru
Copy link
Contributor

drudru commented Jan 23, 2015

BTW - great to see all these recent updates! 👍

@tjk
Copy link
Collaborator

tjk commented Jan 23, 2015

Somewhat related: a lot too many "naked" rescue lying around... many of them could be AT LEAST StandardError so as to avoid ignoring of certain exceptions (ie. SignalException).

@drudru
Copy link
Contributor

drudru commented Jan 23, 2015

Is everything on Ruby 2.x yet?

@sodabrew
Copy link
Collaborator Author

@tjeezy naked rescue is synonymous with rescue StandardError. The problematic code is rescue Exception because that will also catch signals. Documented here:
http://ruby-doc.org/core-1.9.3/StandardError.html
http://ruby-doc.org/core-2.0.0/StandardError.html

@drudru RQ runs on 1.8.7, 1.9.3, 2.0, 2.1, and 2.2 per Travis CI: https://travis-ci.org/brightroll/rq In practice we're mostly using 1.8.7 and 1.9.3.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants