feat: Apply patches from yocto related to Brightsign functionality on top of 28-x-y-bs branch #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
April 29, 2024 11:10
dunfell has clang14. The following changes are required to build Electron with clang14
If Electron is built using ozone, but not with X11 support, compilation fails. HostDisplayClient conditionally compiles DidCompleteSwapWithNewSize with OZONE_PLATFORM_X11 flag. Do the same for our override.
Electron introduces X11 dependencies in wayland ozone platform backend. This is undesired behaviour.
This patch uses a the BrightSign SetZOrderLevel custom Weston extension to enable setting an absolute z-order for a window. Upstream-Status: Unsuitable
This change adds a call to SetOpacity for OZONE_PLATFORM_WAYLAND. It requires patches to Chromium that are included in the BrightSign Electron repo which contain the Chromium changes for supporting SetOpacity in the ozone wayland code. Upstream-Status: Unsuitable
Electron provides no implementation for SetIgnoreMouseEvents when using Wayland. This patch provides uses the Chromium mouse lock functionality to achieve a way of ignoring mouse events when using Wayland. The change goes together with changes in our Electron App to listen to the "focus" event and trigger a call to setIgnoreMouseEvents. This allows us to workaround the issue of mouse lock being automatically disabled when a BrowserWindow gains focus. Using mouse lock for disabling mouse events works fine for our use case.
t-bashir-bs
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Apply the patches in yocto onto Electron repo. This saves us from maintaining two repos for custom functions we are adding.
Checklist
npm testpasses