Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement setting uid and groups for renderer process OS-17053 #58

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

t-bashir-bs
Copy link

Description of Change

Cherry picked changes from QTWebEngine to allow setting the uid and groups
for the renderer process. This is needed to allow the renderer process to
run as a different user and group than the main process.

The parameters are passed via switches --renderer-process-uid and
--renderer-process-gids. A safety check has been added to ensure the
renderer process is not run as root.

Checklist

Release Notes

Notes:

Copy link

@caneraltinbasak caneraltinbasak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try doing the same on preload scripts using process.args and process.setuid, process setgid? If that works, we won't need to modify Chromium source.

@t-bashir-bs t-bashir-bs force-pushed the tbashir/28-x-y-bs-renderer-process-params branch from 109cf4a to 568c419 Compare June 13, 2024 09:37
@t-bashir-bs
Copy link
Author

Can you try doing the same on preload scripts using process.args and process.setuid, process setgid? If that works, we won't need to modify Chromium source.

I tried this but unfortunately only the reduced subset of node process is available:
https://www.electronjs.org/docs/latest/api/process

@t-bashir-bs t-bashir-bs force-pushed the tbashir/28-x-y-bs-renderer-process-params branch from 568c419 to 8169e19 Compare June 13, 2024 09:51
Signed-off-by: Tariq Bashir <120014322+t-bashir-bs@users.noreply.github.com>
@t-bashir-bs t-bashir-bs merged commit 301dfbc into 28-x-y-bs Jun 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants