Fix a type error in ProjectManager's report() function #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8downs
changed the title
|
Nice, thanks! |
|
@n8downs Could you reach out to me at cmutel@gmail.com? I would love to hear about what someone with your background in doing in the sustainability space, and explore opportunities for collaboration. |
|
@cmutel thanks for the great link |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to introspect the state of my
ProjectManagerviabw2data.projects.report()as recommended inProjectManager#__repr__(), but I hit the following error.Looks like a pretty straightforward issue of using pathlib operators where actually we have strings. I've switched to use
Path()and updatedtest_reportto a minimum characterization test that runs the function.I've also added the steps I took to get the environment off the ground to the README, since it wasn't clear (maybe it would be obvious to a more practiced python developer). Feel free to omit that if it's inappropriate or incorrect.