-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sqlite full text search #177
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #177 +/- ##
==========================================
+ Coverage 83.07% 83.24% +0.17%
==========================================
Files 39 39
Lines 3609 3730 +121
==========================================
+ Hits 2998 3105 +107
- Misses 611 625 +14 ☔ View full report in Codecov by Sentry. |
@will7200 Awesome! One small comment which is an easy fix, and then fix some test failures, and we should be GTG! |
on later python versions > 3.11, the weights constructed for the search function are invalid as they include the primary identifier as an arg to `matchinfo`.
24123f3
to
0c61d18
Compare
@cmutel fixed that and found the underlying causing those test failures. The last two remaining windows failures are due to:
Which looks like has happened in past github runs. |
Closes #103
This aims to be a drop in replacement for whoosh. with little to no API change for our customers.
Examples: