Redo #160 #170
Redo #160 #170
Conversation
bw2io/extractors/simapro_csv.py
Outdated
There was a problem hiding this comment.
Hi @ccomb this is not your fault but can I ask you to fix something while we're working on this part? Using Python's native eval is unsave for arbitrary user inputs. Could you change the line to use bw2parameter's DefaultInterpreter instead (or asteval.Interpreter if Chris does not want to make bw2parameters a mandatory dependency)? That would be very helpful :)
There was a problem hiding this comment.
Exxxcccellent idea to remove an eval. I'll look at it this week
There was a problem hiding this comment.
Are we sure asteval is a good choice? I'll read the doc to see if the parser can be configured
>>> asteval.Interpreter().eval("2+2")
4
>>> asteval.Interpreter().eval("2^2")
0
>>> asteval.Interpreter().eval("2**2")
4
>>> asteval.Interpreter().eval("2^-2")
-4
>>> asteval.Interpreter().eval("2**-2")
0
>>> asteval.Interpreter().eval("2.0^-2")
>>> asteval.Interpreter().eval("2.0**-2")
0.25
>>> asteval.Interpreter().eval("2.0^(-2)")
>>> asteval.Interpreter().eval("2.0**(-2)")
0.25
There was a problem hiding this comment.
If we still convert ^ to ** in the input data, the only problem is the evaluation of 2**-2. I've asked as an asteval issue here: https://github.com/newville/asteval/issues/115
There was a problem hiding this comment.
It's ok to merge, with eval replaced with asteval.
But we need a fixed version of asteval
| @@ -15,6 +15,7 @@ | |||
| import re | |||
| import numpy as np | |||
| from stats_arrays import LognormalUncertainty | |||
| import bw2parameters | |||
There was a problem hiding this comment.
This means we have to add bw2parameters to the setup requirements. What do you say @cmutel?
|
Hi @ccomb, Let's move the eval replacement to a new PR and get everything else merged for now. Can you roll back the eval change and make sure all tests are passing? Cheers. |
|
The problem with using only asteval is that the parameter variables are not evaluated and I get a lot of warnings in the console during an ecoinvent import, but I had some troubles with bw2parameter also. I'll try to find some time in the next two or three weeks to find a solution. In the meantime I'll split this PR into smaller ones. |
|
I created another PR #201 with just asteval |
Fix #156 #159 and redo broken PR #160
Don't pin numpy, evaluate expressions in allocations, convert exponent in simapro csv import